Fix path for Chrome DevTools external plugin#1784
Open
aaronpowell wants to merge 2 commits into
Open
Conversation
…n the repo where the plugin structure starts, not where the plugin.json file lives.
github-actions
Bot
added
external-plugin
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns external plugin metadata and website linking behavior with the repository’s external plugin policy by ensuring source.path represents a plugin root folder (or / for repo root), not a plugin.json file path.
Changes:
- Fix external plugin URL generation to treat
source.path: "/"as “repo root” (link to the repo, nottree/main//). - Update the Chrome DevTools external plugin entry to stop pointing
source.pathat a manifest file. - Strengthen and document validation guidance so
source.pathcannot targetplugin.jsondirectly, and clarify the issue template/help text.
Show a summary per file
| File | Description |
|---|---|
| website/src/scripts/pages/plugins-render.ts | Avoids generating a GitHub tree URL when source.path is / (uses repo root instead). |
| website/src/scripts/modal.ts | Same / handling fix for external plugin links in the modal. |
| plugins/external.json | Removes Chrome DevTools source.path that incorrectly pointed at a manifest file; minor keywords formatting normalization. |
| eng/external-plugin-validation.mjs | Allows source.path: "/" and rejects paths that point directly to plugin.json; improves error messaging. |
| CONTRIBUTING.md | Clarifies source.path expectations: / for root or a repo-relative plugin root folder (not plugin.json). |
| .github/plugin/marketplace.json | Updates generated marketplace entry to match corrected external plugin metadata. |
| .github/ISSUE_TEMPLATE/external-plugin.yml | Clarifies what to enter for plugin path and updates the placeholder to a folder path. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.stagedbranch for this pull request.Description
Correct the path for the Chrome DevTools external plugin to point to the correct folder structure in the repository.
Type of Contribution
Additional Notes
No additional information or context for reviewers.
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.